Skip to content

docs: update component ownership guidelines and templates #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pichlermarc merged 5 commits into from
Jan 16, 2025
Merged

docs: update component ownership guidelines and templates #2641

pichlermarc merged 5 commits into from
Jan 16, 2025

Conversation

@pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jan 13, 2025 •
edited
Loading

Which problem is this PR solving?

  • Updates the instrumentation request template to include the ownership requirements checklist (makes the process a bit clearer)
  • Adds documentation that we give triage permissions to component owners (refs Add component owners to js-contrib-triagers role #2600)
  • Adds a recommendation that component owners apply the has:owner-approval label upon approval to signal to maintainers that the PR is ready to merge (reducing time to merge and cutting down on pings for maintainers)
  • Clarifies that a separate repo close to the org that maintains the instrumented package is a feasible location for hosting a instrumentation package (reduces time needed to explain this)

@pichlermarc pichlermarc requested a review from a team as a code owner January 13, 2025 13:01
@pichlermarc pichlermarc mentioned this pull request Jan 13, 2025
Closed
3 tasks
@codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (6b4e532) to head (7a27fc5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2641   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         169      169           
  Lines        8061     8061           
  Branches     1646     1646           
=======================================
  Hits         7319     7319           
  Misses        742      742

maryliag
maryliag reviewed Jan 13, 2025
View reviewed changes
@pichlermarc pichlermarc merged commit e57f3e4 into open-telemetry:main Jan 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maryliag maryliag maryliag approved these changes

@dyladan dyladan dyladan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pichlermarc @maryliag @dyladan